clintropolis commented on a change in pull request #11294:
URL: https://github.com/apache/druid/pull/11294#discussion_r664975278
##########
File path:
server/src/main/java/org/apache/druid/segment/realtime/appenderator/StreamAppenderator.java
##########
@@ -166,7 +166,16 @@
private volatile Throwable persistError;
+
+ /**
+ * Flag to tell internals whether appenderator is working on behalf of a
real time task.
+ * This is to manage certain aspects as needed. For example, for batch,
non-real time tasks,
+ * physical segments (i.e. hydrants) do not need to memory map their
persisted
+ * files. In this case, the code will avoid memory mapping them thus
ameliorating the occurance
+ * of OOMs.
+ */
private final boolean isRealTime;
Review comment:
It is not really though, when the fallback is set to true,
`StreamAppenderator` is made with isRealtime hard coded to false, instead of
controlled by a flag as was introduced in #11123. This means there is no way to
revert the behavior of that PR since it isn't operator controllable anymore.
Rather than introduce a 2nd flag, I strongly think we should consider removing
the isRealtime from `StreamAppenderator` before 0.22 since the behavior was
previously unreleased and now there is no way to not use it (I don't think
there is enough time to have no setting at all and always use
`BatchAppenderator`, so that flag will still need to exist to choose between
them).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
