loquisgon commented on a change in pull request #11294:
URL: https://github.com/apache/druid/pull/11294#discussion_r664967315



##########
File path: 
server/src/main/java/org/apache/druid/segment/realtime/appenderator/StreamAppenderator.java
##########
@@ -166,7 +166,16 @@
 
   private volatile Throwable persistError;
 
+
+  /**
+   * Flag to tell internals whether appenderator is working on behalf of a 
real time task.
+   * This is to manage certain aspects as needed. For example, for batch, 
non-real time tasks,
+   * physical segments (i.e. hydrants) do not need to memory map their 
persisted
+   * files. In this case, the code will avoid memory mapping them thus 
ameliorating the occurance
+   * of OOMs.
+   */
   private final boolean isRealTime;

Review comment:
       It is used for the fall back flag.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to