clintropolis commented on a change in pull request #11294:
URL: https://github.com/apache/druid/pull/11294#discussion_r664973951
##########
File path: docs/configuration/index.md
##########
@@ -1334,7 +1334,7 @@ Additional peon configs include:
|`druid.peon.mode`|Choices are "local" and "remote". Setting this to local
means you intend to run the peon as a standalone process (Not
recommended).|remote|
|`druid.indexer.task.baseDir`|Base temporary working
directory.|`System.getProperty("java.io.tmpdir")`|
|`druid.indexer.task.baseTaskDir`|Base temporary working directory for
tasks.|`${druid.indexer.task.baseDir}/persistent/task`|
-|`druid.indexer.task.batchMemoryMappedIndex`|If false, native batch ingestion
will not map indexes thus saving heap space. This does not apply to streaming
ingestion, just to batch. This setting should only be used when a bug is
suspected or found in the new batch ingestion code that avoids memory mapping
indices. If a bug is suspected or found, you can set this flag to `true` to
fall back to previous, working but more memory intensive, code path.|`false`|
+|`druid.indexer.task.batchFallback`|If false, native batch ingestion will use
memory optimized code. This does not apply to streaming ingestion, just to
batch. This setting should only be used when a bug is suspected or found in the
new optimized batch ingestion code. If a bug is suspected or found, you can set
this flag to `true` to fall back to previous, working but more memory
intensive, code path.|`false`|
Review comment:
I'm making the 0.22 branch likely in the next week, so it seems to me
that the flag _must_ exist to provide a way to revert to 0.21 behavior for at
least 1 release cycle I think. `batchMemoryMappedIndex` is not in 0.21, so has
never been released.
Since this flag will be release, I still think I assert that it should have
a better name, inverted or not, I don't see a good argument to leave it
intentionally vague.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
