clintropolis opened a new pull request #12315:
URL: https://github.com/apache/druid/pull/12315
### Description
This PR updates the `BitmapIndex` interface to add several "value" based
bitmap retrieval methods, to push the logic of how these are collected into the
`BitmapIndex` implementation, instead of leaking details about the underlying
dictionaries (such as GenericIndexed.indexOf returning position or -insertion
point).
```
ImmutableBitmap getBitmapForValue(@Nullable String value);
default Iterable<ImmutableBitmap> getBitmapsInRange(
@Nullable String startValue,
boolean startStrict,
@Nullable String endValue,
boolean endStrict
)
{
return getBitmapsInRange(startValue, startStrict, endValue, endStrict,
(index) -> true);
}
Iterable<ImmutableBitmap> getBitmapsInRange(
@Nullable String startValue,
boolean startStrict,
@Nullable String endValue,
boolean endStrict,
IntPredicate matcher
);
Iterable<ImmutableBitmap> getBitmapsForValues(Set<String> values);
```
I consider this the first step of some work I'd like to do on allowing
indexes on other types of values, such as numbers and complex types.
<hr>
##### Key changed/added classes in this PR
* `BitmapIndex`
* `BitmapIndexSelector`
* `StringBitmapIndexColumnPartSupplier`
* `InDimFilter`
* `BoundFilter`
* `LikeFilter`
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
