clintropolis commented on a change in pull request #12315:
URL: https://github.com/apache/druid/pull/12315#discussion_r822286062
##########
File path:
processing/src/main/java/org/apache/druid/segment/ColumnSelectorBitmapIndexSelector.java
##########
@@ -264,6 +265,78 @@ public ImmutableBitmap getBitmap(int idx)
return bitmapFactory.makeEmptyImmutableBitmap();
}
}
+
+ @Override
+ public ImmutableBitmap getBitmapForValue(@Nullable String value)
+ {
+ if (NullHandling.isNullOrEquivalent(value)) {
+ return
bitmapFactory.complement(bitmapFactory.makeEmptyImmutableBitmap(),
getNumRows());
+ } else {
+ return bitmapFactory.makeEmptyImmutableBitmap();
+ }
+ }
+
+ @Override
+ public Iterable<ImmutableBitmap> getBitmapsInRange(
Review comment:
oops yes, I meant to revisit this one. I started with copying the
existing path it was taking but forgot about it; it should be better now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
