clintropolis commented on a change in pull request #12315:
URL: https://github.com/apache/druid/pull/12315#discussion_r822448662
##########
File path: processing/src/main/java/org/apache/druid/segment/data/Indexed.java
##########
@@ -55,8 +55,8 @@
int indexOf(@Nullable T value);
/**
- * Returns the index of "value" in some object whose values are accessible
by index some {@link IndexedGetter}, or
- * (-(insertion point) - 1) if the value is not present, in the manner of
Arrays.binarySearch.
+ * Returns the index of "value" in some object in the {@link Indexed}, or
(-(insertion point) - 1) if the value is
+ * not present, in the manner of Arrays.binarySearch.
Review comment:
i just killed this method and moved this logic into `GenericIndexed`
which was the only caller again after the changes in this PR. I think it is ok
for `GenericIndexed.indexOf` to mention that it has this contract for
`indexOf`, since it is an implementation detail that the `BitmapIndex`
implementation of `StringBitmapIndexColumnPartSupplier` cares about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
