clintropolis commented on a change in pull request #12315:
URL: https://github.com/apache/druid/pull/12315#discussion_r822286661
##########
File path:
processing/src/main/java/org/apache/druid/segment/serde/StringBitmapIndexColumnPartSupplier.java
##########
@@ -94,6 +101,179 @@ public ImmutableBitmap getBitmap(int idx)
final ImmutableBitmap bitmap = bitmaps.get(idx);
return bitmap == null ? bitmapFactory.makeEmptyImmutableBitmap() :
bitmap;
}
+
+ @Override
+ public ImmutableBitmap getBitmapForValue(@Nullable String value)
+ {
+ final int idx = dictionary.indexOf(value);
+ return getBitmap(idx);
+ }
+
+ @Override
+ public Iterable<ImmutableBitmap> getBitmapsInRange(
+ @Nullable String startValue,
+ boolean startStrict,
+ @Nullable String endValue,
+ boolean endStrict
+ )
+ {
+ int startIndex, endIndex;
+ if (startValue == null) {
+ startIndex = 0;
+ } else {
+ final int found =
dictionary.indexOf(NullHandling.emptyToNullIfNeeded(startValue));
+ if (found >= 0) {
+ startIndex = startStrict ? found + 1 : found;
+ } else {
+ startIndex = -(found + 1);
+ }
+ }
+
+ if (endValue == null) {
+ endIndex = dictionary.size();
+ } else {
+ final int found =
dictionary.indexOf(NullHandling.emptyToNullIfNeeded(endValue));
+ if (found >= 0) {
+ endIndex = endStrict ? found : found + 1;
+ } else {
+ endIndex = -(found + 1);
+ }
+ }
+
+ endIndex = startIndex > endIndex ? startIndex : endIndex;
+ final IntIterator rangeIterator = IntListUtils.fromTo(startIndex,
endIndex).iterator();
+ return () -> new Iterator<ImmutableBitmap>()
Review comment:
good catch. I'm not really sure they need to be `Iterable`, I was just
matching the pattern being used externally on top of `BitmapIndex`, so I just
fixed it instead of changing them to `Iterator` for now, but will revisit this
later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
