suneet-s commented on code in PR #12472:
URL: https://github.com/apache/druid/pull/12472#discussion_r856357386


##########
processing/src/main/java/org/apache/druid/query/timeboundary/TimeBoundaryQueryRunnerFactory.java:
##########
@@ -155,7 +156,8 @@ public Iterator<Result<TimeBoundaryResultValue>> make()
               final DateTime minTime;
               final DateTime maxTime;
 
-              if (legacyQuery.getFilter() != null) {
+              Interval queryInterval = 
legacyQuery.getQuerySegmentSpec().getIntervals().get(0);

Review Comment:
   Are we guaranteed that `getIntervals()` will always return a list with at 
least one element?
   
   There are no javadocs on `QuerySegmentSpec#getIntervals()` so I'm not sure 
if a future implementation may choose to return an empty intervals.
   
   NOTE to self: Why do we need this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to