rohangarg commented on code in PR #12472:
URL: https://github.com/apache/druid/pull/12472#discussion_r857106769
##########
processing/src/main/java/org/apache/druid/query/timeboundary/TimeBoundaryQueryRunnerFactory.java:
##########
@@ -155,7 +156,8 @@ public Iterator<Result<TimeBoundaryResultValue>> make()
final DateTime minTime;
final DateTime maxTime;
- if (legacyQuery.getFilter() != null) {
+ Interval queryInterval =
legacyQuery.getQuerySegmentSpec().getIntervals().get(0);
Review Comment:
I've improved the code for checking the containment of the adapter interval.
Does it look ok now? Now, it always expects exactly 1 interval as other engines
do. But still empty intervals pass in timeBoundary because the broker code
doesn't generate query runners incase empty intervals are given.
For null intervals (which seems like a valid case for timeBoundary), the
query object itself creates an eternity interval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
