suneet-s commented on code in PR #12472:
URL: https://github.com/apache/druid/pull/12472#discussion_r857242874
##########
processing/src/main/java/org/apache/druid/query/timeboundary/TimeBoundaryQueryRunnerFactory.java:
##########
@@ -155,7 +157,7 @@ public Iterator<Result<TimeBoundaryResultValue>> make()
final DateTime minTime;
final DateTime maxTime;
- if (legacyQuery.getFilter() != null) {
+ if (legacyQuery.getFilter() != null ||
!queryIntervalContainsAdapterInterval()) {
Review Comment:
If the query interval does not contain the adapter interval - should we just
set minTime and maxTime to null?
I think that's what is happening here when we call `getTimeBoundary` on line
161 except it looks like we iterate through the cursor before finding no
matches. It probably isn't too big of a deal since the TImeBoundaryQuery
doesn't operate on every segment (at least if my understanding is correct).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
