rohangarg commented on code in PR #12472:
URL: https://github.com/apache/druid/pull/12472#discussion_r857379194
##########
processing/src/main/java/org/apache/druid/query/timeboundary/TimeBoundaryQueryRunnerFactory.java:
##########
@@ -155,7 +157,7 @@ public Iterator<Result<TimeBoundaryResultValue>> make()
final DateTime minTime;
final DateTime maxTime;
- if (legacyQuery.getFilter() != null) {
+ if (legacyQuery.getFilter() != null ||
!queryIntervalContainsAdapterInterval()) {
Review Comment:
There could still be some overlap between the intervals which could mean
that minTime and maxTime could exist. For those cases, we'd need
`getTimeBoundary` to look through the cursor and find the appropriate rows.
If there is now row with non-null time in that range, then yes as you
mentioned we'd be returning null minTime and maxTime
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
