clintropolis commented on code in PR #12953:
URL: https://github.com/apache/druid/pull/12953#discussion_r954883454
##########
processing/src/main/java/org/apache/druid/segment/LongDimensionIndexer.java:
##########
@@ -47,7 +48,7 @@ public class LongDimensionIndexer implements
DimensionIndexer<Long, Long, Long>
public EncodedKeyComponent<Long>
processRowValsToUnsortedEncodedKeyComponent(@Nullable Object dimValues, boolean
reportParseExceptions)
{
if (dimValues instanceof List) {
- throw new UnsupportedOperationException("Numeric columns do not support
multivalue rows.");
+ throw new ParseException(null, "Numeric columns do not support
multivalue rows.");
}
Review Comment:
i don't feel that strongly about it so don't let me block this PR. I'm
mostly just wondering what is special about the List type that it deserves its
own error message.
If the input was from like say an array function transform it would be
`Object[]` and not caught by the check.
If it were a list of map (like from list of json objects or whatever) so
would be strings of that instead of numbers, and the error doesn't make quite
as much sense either I would think. And so on, for other types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
