abhishekagarwal87 commented on code in PR #12953:
URL: https://github.com/apache/druid/pull/12953#discussion_r955803169
##########
processing/src/main/java/org/apache/druid/segment/LongDimensionIndexer.java:
##########
@@ -47,7 +48,7 @@ public class LongDimensionIndexer implements
DimensionIndexer<Long, Long, Long>
public EncodedKeyComponent<Long>
processRowValsToUnsortedEncodedKeyComponent(@Nullable Object dimValues, boolean
reportParseExceptions)
{
if (dimValues instanceof List) {
- throw new UnsupportedOperationException("Numeric columns do not support
multivalue rows.");
+ throw new ParseException(null, "Numeric columns do not support
multivalue rows.");
}
Review Comment:
Users are most likely to run into this scenario where they are ingesting the
data directly without transforms in between. IMO a more plain error message
will users connect the dots faster than an error message that has java class
names. Because the latter error message would appear as an internal issue on
the face.
If you are saying that we should be returning similar error messages for
other types too, I agree. but in absence of that, we do the best we can. we
could even add a utility method that can translate a java type classname to
something more friendly (HashMap --> map). and then folks can use it where
they want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
