clintropolis commented on code in PR #12953:
URL: https://github.com/apache/druid/pull/12953#discussion_r953552198
##########
processing/src/main/java/org/apache/druid/segment/LongDimensionIndexer.java:
##########
@@ -47,7 +48,7 @@ public class LongDimensionIndexer implements
DimensionIndexer<Long, Long, Long>
public EncodedKeyComponent<Long>
processRowValsToUnsortedEncodedKeyComponent(@Nullable Object dimValues, boolean
reportParseExceptions)
{
if (dimValues instanceof List) {
- throw new UnsupportedOperationException("Numeric columns do not support
multivalue rows.");
+ throw new ParseException(null, "Numeric columns do not support
multivalue rows.");
}
Review Comment:
I think the exception should probably read "invalid type" or "incompatible
type" instead of "unknown type". I guess my objection is that i'm not sure the
multivalue rows part is actually that useful.
If i have my way there will _never_ be another multi-value anything in favor
of using `ARRAY` types, so in that world these numeric value indexers will
never support list or array or anything else other than stuff that can be
converted to numbers, so I'm not sure its useful to specifically call out that
"Numeric columns do not support multivalue rows".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
