kfaraz commented on code in PR #12953:
URL: https://github.com/apache/druid/pull/12953#discussion_r953547425
##########
processing/src/main/java/org/apache/druid/segment/LongDimensionIndexer.java:
##########
@@ -47,7 +48,7 @@ public class LongDimensionIndexer implements
DimensionIndexer<Long, Long, Long>
public EncodedKeyComponent<Long>
processRowValsToUnsortedEncodedKeyComponent(@Nullable Object dimValues, boolean
reportParseExceptions)
{
if (dimValues instanceof List) {
- throw new UnsupportedOperationException("Numeric columns do not support
multivalue rows.");
+ throw new ParseException(null, "Numeric columns do not support
multivalue rows.");
}
Review Comment:
Yeah, I guess we can leave the check to
`DimensionHandlerUtils.convertObjectToLong` and other equivalent methods.
But in that case, we should have a proper error message there. Currently,
`DimensionHandlerUtils` would just throw a `ParseException` with the message
"Unknown type".
Do you suggest we move the `instanceof List` check to
`DimensionHandlerUtils.convertObjectToLong`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
