adarshsanjeev commented on code in PR #12998:
URL: https://github.com/apache/druid/pull/12998#discussion_r958444478
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/statistics/DistinctKeyCollector.java:
##########
@@ -43,8 +43,8 @@
*/
public class DistinctKeyCollector implements KeyCollector<DistinctKeyCollector>
{
- static final int INITIAL_MAX_KEYS = 2 << 15 /* 65,536 */;
- static final int SMALLEST_MAX_KEYS = 16;
+ static final int INITIAL_MAX_BYTES = 5_120_000;
+ static final int SMALLEST_MAX_BYTES = 5000;
Review Comment:
I'm not sure if these are the best thresholds here and for
PARTITION_STATS_MAX_BYTES.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
