adarshsanjeev commented on code in PR #12998:
URL: https://github.com/apache/druid/pull/12998#discussion_r969188218
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/statistics/QuantilesSketchKeyCollector.java:
##########
@@ -42,23 +42,29 @@ public class QuantilesSketchKeyCollector implements
KeyCollector<QuantilesSketch
{
private final Comparator<RowKey> comparator;
private ItemsSketch<RowKey> sketch;
+ private double averageKeyLength;
QuantilesSketchKeyCollector(
final Comparator<RowKey> comparator,
- @Nullable final ItemsSketch<RowKey> sketch
+ @Nullable final ItemsSketch<RowKey> sketch,
+ double averageKeyLength
)
{
this.comparator = comparator;
this.sketch = sketch;
+ this.averageKeyLength = averageKeyLength;
}
@Override
public void add(RowKey key, long weight)
{
+ double total = averageKeyLength * sketch.getN();
+ total += key.array().length * weight;
for (int i = 0; i < weight; i++) {
// Add the same key multiple times to make it "heavier".
sketch.update(key);
Review Comment:
Added a comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
