cryptoe commented on code in PR #12998:
URL: https://github.com/apache/druid/pull/12998#discussion_r970704779
##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/statistics/DelegateOrMinKeyCollectorTest.java:
##########
@@ -78,12 +85,13 @@ public void testAdd()
QuantilesSketchKeyCollectorFactory.create(clusterBy)
).newKeyCollector();
- collector.add(createKey(1L), 1);
+ RowKey key = createKey(1L);
+ collector.add(key, 1);
Assert.assertTrue(collector.getDelegate().isPresent());
Review Comment:
So one sketch should have 2 records with avg key size as 10 bytes and the
other sketch should have 5 records with avg key size of lets say 100 bytes.
Then see the new addAll sktech as the correct avgKeySize.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
