cryptoe commented on code in PR #12998:
URL: https://github.com/apache/druid/pull/12998#discussion_r972136501
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/statistics/DistinctKeyCollector.java:
##########
@@ -43,8 +43,8 @@
*/
public class DistinctKeyCollector implements KeyCollector<DistinctKeyCollector>
{
- static final int INITIAL_MAX_KEYS = 2 << 15 /* 65,536 */;
- static final int SMALLEST_MAX_KEYS = 16;
+ static final int INITIAL_MAX_BYTES = 5_120_000;
Review Comment:
Also, I think we should bump this up to 300 MB in my view. We generally set
3 gig per worker so 10% of that should be a good start I think .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
