somu-imply commented on code in PR #13085:
URL: https://github.com/apache/druid/pull/13085#discussion_r993824681
##########
processing/src/main/java/org/apache/druid/query/Queries.java:
##########
@@ -191,11 +191,19 @@ public static <T> Query<T> withBaseDataSource(final
Query<T> query, final DataSo
{
final Query<T> retVal;
- if (query.getDataSource() instanceof QueryDataSource) {
- final Query<?> subQuery = ((QueryDataSource)
query.getDataSource()).getQuery();
+ /*
+ * Currently, this method is implemented in terms of a static walk doing a
bunch of instanceof checks.
+ * We should likely look into moving this functionality into the
DataSource object itself so that they
+ * can walk and create new objects on their own. This will be necessary
as we expand the set of DataSources
+ * that do actual work, as each of them will need to show up in this
if/then waterfall.
+ */
Review Comment:
@cheddar this was moved to the `DataSource` , no more `instanceof` checks
here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
