abhishekagarwal87 commented on code in PR #13085:
URL: https://github.com/apache/druid/pull/13085#discussion_r995590968
##########
core/src/main/java/org/apache/druid/math/expr/ExprMacroTable.java:
##########
@@ -44,6 +44,7 @@
{
private static final ExprMacroTable NIL = new
ExprMacroTable(Collections.emptyList());
+
Review Comment:
this change is not needed.
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/BaseLeafFrameProcessor.java:
##########
@@ -152,13 +153,24 @@ private boolean initializeSegmentMapFn(final IntSet
readableInputs)
segmentMapFn = Function.identity();
return true;
} else {
- final boolean retVal =
broadcastJoinHelper.buildBroadcastTablesIncrementally(readableInputs);
-
- if (retVal) {
- segmentMapFn = broadcastJoinHelper.makeSegmentMapFn(query);
+ if (query.getDataSource() instanceof InputNumberDataSource) {
Review Comment:
It seems earlier a `segmentMapFn` gets created even when
`InputNumberDataSource` is a child datasource. but not now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
