AmatyaAvadhanula commented on code in PR #13238:
URL: https://github.com/apache/druid/pull/13238#discussion_r1014069062
##########
server/src/main/java/org/apache/druid/segment/realtime/RealtimeMetricsMonitor.java:
##########
@@ -137,6 +114,12 @@ public boolean doMonitor(ServiceEmitter emitter)
emitter.emit(builder.build("ingest/handoff/count",
metrics.handOffCount() - previous.handOffCount()));
emitter.emit(builder.build("ingest/sink/count", metrics.sinkCount()));
emitter.emit(builder.build("ingest/events/messageGap",
metrics.messageGap()));
+
+ long maxSegmentHandoffTime = metrics.maxSegmentHandoffTime();
+ if (maxSegmentHandoffTime >= 0) {
+ emitter.emit(builder.build("ingest/handoff/time",
maxSegmentHandoffTime));
Review Comment:
I think this metric isn't of much value when segments aren't being handed
off and emitting 0 wouldn't be very helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
