kfaraz commented on code in PR #13238:
URL: https://github.com/apache/druid/pull/13238#discussion_r1007651333
##########
server/src/main/java/org/apache/druid/segment/realtime/appenderator/StreamAppenderatorDriver.java:
##########
@@ -359,6 +360,7 @@ public void onSuccess(Object result)
if (numRemainingHandoffSegments.decrementAndGet() == 0) {
List<DataSegment> segments =
segmentsAndCommitMetadata.getSegments();
log.debug("Successfully handed off [%d] segments.",
segments.size());
+
metrics.reportMaxSegmentHandoffTime(System.currentTimeMillis() -
handoffStartTime);
Review Comment:
@AmatyaAvadhanula , we just need to log here for someone debugging an issue
to find. We need not raise an alert here. That said, a 10 or 15 min threshold
seems fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]