AmatyaAvadhanula commented on code in PR #13238:
URL: https://github.com/apache/druid/pull/13238#discussion_r1006806250
##########
server/src/main/java/org/apache/druid/segment/realtime/appenderator/StreamAppenderatorDriver.java:
##########
@@ -359,6 +360,7 @@ public void onSuccess(Object result)
if (numRemainingHandoffSegments.decrementAndGet() == 0) {
List<DataSegment> segments =
segmentsAndCommitMetadata.getSegments();
log.debug("Successfully handed off [%d] segments.",
segments.size());
+
metrics.reportMaxSegmentHandoffTime(System.currentTimeMillis() -
handoffStartTime);
Review Comment:
@abhishekagarwal87, as @kfaraz has pointed out, it seems difficult to get a
good threshold since long coodinator times may affect the handoff period.
Does 15 or maybe 30 mins seem like a good threshold to avoid too many alerts
on large clusters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
