AmatyaAvadhanula commented on code in PR #13238:
URL: https://github.com/apache/druid/pull/13238#discussion_r1005249963
##########
core/src/main/java/org/apache/druid/java/util/metrics/ParametrizedUriEmitterMonitor.java:
##########
@@ -65,6 +65,13 @@ public void stop()
super.stop();
}
+ @Override
+ public void stopAfterLastRoundOfMetricsEmission(ServiceEmitter emitter)
+ {
+ monitors.values().forEach(monitor ->
monitor.stopAfterLastRoundOfMetricsEmission(emitter));
Review Comment:
updateMonitors() seems to be called in doMonitor which is called by monitor.
monitorAndStop() may not have to call this method explicitly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
