kfaraz commented on code in PR #13411:
URL: https://github.com/apache/druid/pull/13411#discussion_r1029080002
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -2014,9 +2014,24 @@ private void resumeAllActivelyReadingTasks()
}
Map<String, ListenableFuture<Boolean>> tasksToResume = new HashMap<>();
+ if (activelyReadingTaskGroups.isEmpty()) {
+ return;
+ }
+ // Resume only running tasks and not pending / waiting ones.
+ if (!taskMaster.getTaskRunner().isPresent()) {
+ return;
+ }
+ Set<String> runningTaskIds = taskMaster.getTaskRunner()
+ .get()
+ .getRunningTasks()
Review Comment:
Just catching up here, isn't the issue that we kill off RUNNING tasks which
are actively processing data/publishing segments? Or were we killing off
WAITING tasks?
IIUC, the existing flow wouldn't affect PENDING or WAITING tasks anyway, as
they haven't started execution yet (unless they just started execution and we
don't have the synced state yet).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
