AmatyaAvadhanula commented on code in PR #13411:
URL: https://github.com/apache/druid/pull/13411#discussion_r1031469357
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -2014,9 +2014,24 @@ private void resumeAllActivelyReadingTasks()
}
Map<String, ListenableFuture<Boolean>> tasksToResume = new HashMap<>();
+ if (activelyReadingTaskGroups.isEmpty()) {
+ return;
+ }
+ // Resume only running tasks and not pending / waiting ones.
+ if (!taskMaster.getTaskRunner().isPresent()) {
+ return;
+ }
+ Set<String> runningTaskIds = taskMaster.getTaskRunner()
+ .get()
+ .getRunningTasks()
Review Comment:
Killing pending tasks of a supervisor could lead to increased lag as it must
re-create these tasks in the next run.
The failure could also be misleading as one cannot resume a task that hasn't
begun running
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
