AmatyaAvadhanula commented on code in PR #13411:
URL: https://github.com/apache/druid/pull/13411#discussion_r1029116418
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -2014,9 +2014,24 @@ private void resumeAllActivelyReadingTasks()
}
Map<String, ListenableFuture<Boolean>> tasksToResume = new HashMap<>();
+ if (activelyReadingTaskGroups.isEmpty()) {
+ return;
+ }
+ // Resume only running tasks and not pending / waiting ones.
+ if (!taskMaster.getTaskRunner().isPresent()) {
+ return;
+ }
+ Set<String> runningTaskIds = taskMaster.getTaskRunner()
+ .get()
+ .getRunningTasks()
Review Comment:
The code introduced in #13223 tried to resume any task in the set of
`activelyReadingTaskGroups` irrespective of the task runner worker status and
killed the task if it failed to respond with a successful status.
The issue was that there were PENDING / WAITING tasks in the set which
couldn't respond to this request as they hadn't even begun RUNNING, and were
killed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
