kfaraz commented on code in PR #13411:
URL: https://github.com/apache/druid/pull/13411#discussion_r1031463430
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -2014,9 +2014,24 @@ private void resumeAllActivelyReadingTasks()
}
Map<String, ListenableFuture<Boolean>> tasksToResume = new HashMap<>();
+ if (activelyReadingTaskGroups.isEmpty()) {
+ return;
+ }
+ // Resume only running tasks and not pending / waiting ones.
+ if (!taskMaster.getTaskRunner().isPresent()) {
+ return;
+ }
+ Set<String> runningTaskIds = taskMaster.getTaskRunner()
+ .get()
+ .getRunningTasks()
Review Comment:
Makes sense.
Have we seen a specific drawback of killing off PENDING/WAITING tasks or a
race condition that may have adverse effects, or is this PR just a safety
measure to avoid unnecessary operations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
