techdocsmith commented on code in PR #13524: URL: https://github.com/apache/druid/pull/13524#discussion_r1051167497
########## docs/development/extensions-core/datasketches-hll.md: ########## @@ -23,29 +23,32 @@ title: "DataSketches HLL Sketch module" --> -This module provides Apache Druid aggregators for distinct counting based on HLL sketch from [Apache DataSketches](https://datasketches.apache.org/) library. At ingestion time, this aggregator creates the HLL sketch objects to be stored in Druid segments. At query time, sketches are read and merged together. In the end, by default, you receive the estimate of the number of distinct values presented to the sketch. Also, you can use post aggregator to produce a union of sketch columns in the same row. -You can use the HLL sketch aggregator on columns of any identifiers. It will return estimated cardinality of the column. +This module provides Apache Druid aggregators for distinct counting based on HLL sketch from [Apache DataSketches](https://datasketches.apache.org/) library. At ingestion time, this aggregator creates the HLL sketch objects to be stored in Druid segments. At query time, sketches are read and merged together. In the end, by default, you receive the estimate of the number of distinct values presented to the sketch. Also, you can use post aggregators to produce a union of sketch columns in the same row. +You can use the HLL sketch aggregator on any column to estimate its cardinality. To use this aggregator, make sure you [include](../../development/extensions.md#loading-extensions) the extension in your config file: ``` druid.extensions.loadList=["druid-datasketches"] ``` -### Aggregators +For additional sketch types supported in Druid, see [DataSketches extension](datasketches-extension.md). -|property|description|required?| +## Aggregators + +|Property|Description|Required?| |--------|-----------|---------| -|`type`|This String should be [`HLLSketchBuild`](#hllsketchbuild-aggregator) or [`HLLSketchMerge`](#hllsketchmerge-aggregator)|yes| -|`name`|A String for the output (result) name of the calculation.|yes| -|`fieldName`|A String for the name of the input field.|yes| +|`type`|This string should be [`HLLSketchBuild`](#hllsketchbuild-aggregator) or [`HLLSketchMerge`](#hllsketchmerge-aggregator).|yes| +|`name`|A string for the output (result) name of the calculation.|yes| Review Comment: ```suggestion |`name`|String representing the output column to store sketch values.|yes| ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
