techdocsmith commented on code in PR #13524: URL: https://github.com/apache/druid/pull/13524#discussion_r1051170516
########## docs/development/extensions-core/datasketches-quantiles.md: ########## @@ -50,17 +52,18 @@ The result of the aggregation is a DoublesSketch that is the union of all sketch } ``` -|property|description|required?| +|Property|Description|Required?| |--------|-----------|---------| -|type|This String should always be "quantilesDoublesSketch"|yes| -|name|A String for the output (result) name of the calculation.|yes| -|fieldName|A String for the name of the input field (can contain sketches or raw numeric values).|yes| -|k|Parameter that determines the accuracy and size of the sketch. Higher k means higher accuracy but more space to store sketches. Must be a power of 2 from 2 to 32768. See [accuracy information](https://datasketches.apache.org/docs/Quantiles/OrigQuantilesSketch) in the DataSketches documentation for details.|no, defaults to 128| -|maxStreamLength|This parameter defines the number of items that can be presented to each sketch before it may need to move from off-heap to on-heap memory. This is relevant to query types that use off-heap memory, including [TopN](../../querying/topnquery.md) and [GroupBy](../../querying/groupbyquery.md). Ideally, should be set high enough such that most sketches can stay off-heap.|no, defaults to 1000000000| +|`type`|This string should always be "quantilesDoublesSketch"|yes| +|`name`|A string for the output (result) name of the calculation.|yes| Review Comment: ```suggestion |`name`|String representing the output column to store sketch values.|yes| ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
