techdocsmith commented on code in PR #13524:
URL: https://github.com/apache/druid/pull/13524#discussion_r1051172477


##########
docs/development/extensions-core/datasketches-theta.md:
##########
@@ -45,17 +50,18 @@ druid.extensions.loadList=["druid-datasketches"]
  }
 ```
 
-|property|description|required?|
+|Property|Description|Required?|
 |--------|-----------|---------|
-|type|This String should always be "thetaSketch"|yes|
-|name|A String for the output (result) name of the calculation.|yes|
-|fieldName|A String for the name of the aggregator used at ingestion time.|yes|
-|isInputThetaSketch|This should only be used at indexing time if your input 
data contains theta sketch objects. This would be the case if you use 
datasketches library outside of Druid, say with Pig/Hive, to produce the data 
that you are ingesting into Druid |no, defaults to false|
-|size|Must be a power of 2. Internally, size refers to the maximum number of 
entries sketch object will retain. Higher size means higher accuracy but more 
space to store sketches. Note that after you index with a particular size, 
druid will persist sketch in segments and you will use size greater or equal to 
that at query time. See the [DataSketches 
site](https://datasketches.apache.org/docs/Theta/ThetaSize) for details. In 
general, We recommend just sticking to default size. |no, defaults to 16384|
+|`type`|This string should always be "thetaSketch"|yes|
+|`name`|A string for the output (result) name of the calculation.|yes|
+|`fieldName`|A string for the name of the aggregator used at ingestion 
time.|yes|
+|`isInputThetaSketch`|This should only be used at indexing time if your input 
data contains theta sketch objects. This would be the case if you use 
datasketches library outside of Druid, say with Pig/Hive, to produce the data 
that you are ingesting into Druid |no, defaults to false|

Review Comment:
   ```suggestion
   |`isInputThetaSketch`|Only set this to true at indexing time if your input 
data contains Theta sketch objects. This applies to cases when you use 
DataSketches library outside of Druid, Pig/Hive for example, to produce the 
data to ingest into Druid |no, defaults to false|
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to