kfaraz commented on code in PR #13524: URL: https://github.com/apache/druid/pull/13524#discussion_r1044393334
########## docs/development/extensions-core/datasketches-hll.md: ########## @@ -23,29 +23,32 @@ title: "DataSketches HLL Sketch module" --> -This module provides Apache Druid aggregators for distinct counting based on HLL sketch from [Apache DataSketches](https://datasketches.apache.org/) library. At ingestion time, this aggregator creates the HLL sketch objects to be stored in Druid segments. At query time, sketches are read and merged together. In the end, by default, you receive the estimate of the number of distinct values presented to the sketch. Also, you can use post aggregator to produce a union of sketch columns in the same row. -You can use the HLL sketch aggregator on columns of any identifiers. It will return estimated cardinality of the column. +This module provides Apache Druid aggregators for distinct counting based on HLL sketch from [Apache DataSketches](https://datasketches.apache.org/) library. At ingestion time, this aggregator creates the HLL sketch objects to be stored in Druid segments. At query time, sketches are read and merged together. In the end, by default, you receive the estimate of the number of distinct values presented to the sketch. Also, you can use post aggregators to produce a union of sketch columns in the same row. +You can use the HLL sketch aggregator on columns of any identifiers. It will return the estimated cardinality of the column. Review Comment: Not sure what `columns of any idenfiers` means. I guess a rephrase might help ```suggestion You can use the HLL sketch aggregator on any column to estimate its cardinality. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
