clintropolis commented on code in PR #13672:
URL: https://github.com/apache/druid/pull/13672#discussion_r1070878997
##########
core/src/main/java/org/apache/druid/java/util/common/parsers/ObjectFlatteners.java:
##########
@@ -218,9 +219,9 @@ public Map<String, Object> toMap(T obj)
{
JsonProvider getJsonProvider();
/**
- * List all "root" primitive properties and primitive lists (no nested
objects, no lists of objects)
+ * List all "root" fields, optionally filtering to include only fields
that contain primitive and lists of primitive values
*/
- Iterable<String> discoverRootFields(T obj);
+ Iterable<String> discoverRootFields(T obj, boolean discoverNestedFields);
Review Comment:
yeah, i guess I was thinking doing it this way would force implementors to
be aware that the contract is a bit different (or at least will be), though
maybe it is nicer to push into the `FlattenerMaker` constructors instead and we
just mention in the release notes that implementors should try to honor the
mode for their readers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
