imply-cheddar commented on code in PR #13672:
URL: https://github.com/apache/druid/pull/13672#discussion_r1080772845
##########
core/src/main/java/org/apache/druid/data/input/impl/DimensionsSpec.java:
##########
@@ -78,15 +80,16 @@ public static Builder builder()
public DimensionsSpec(List<DimensionSchema> dimensions)
{
- this(dimensions, null, null, false);
+ this(dimensions, null, null, false, null);
}
@JsonCreator
private DimensionsSpec(
@JsonProperty("dimensions") List<DimensionSchema> dimensions,
@JsonProperty("dimensionExclusions") List<String> dimensionExclusions,
@Deprecated @JsonProperty("spatialDimensions")
List<SpatialDimensionSchema> spatialDimensions,
- @JsonProperty("includeAllDimensions") boolean includeAllDimensions
+ @JsonProperty("includeAllDimensions") boolean includeAllDimensions,
+ @JsonProperty("useNestedColumnIndexerForSchemaDiscovery") Boolean
useNestedColumnIndexerForSchemaDiscovery
Review Comment:
how about a shorter name? `"discoverNested"`?
##########
extensions-core/orc-extensions/src/main/java/org/apache/druid/data/input/orc/OrcStructFlattenerMaker.java:
##########
@@ -43,7 +43,9 @@ public class OrcStructFlattenerMaker implements
ObjectFlatteners.FlattenerMaker<
private final JsonProvider orcJsonProvider;
private final OrcStructConverter converter;
- OrcStructFlattenerMaker(boolean binaryAsString)
+ private final boolean discoverNestedFields;
+
+ OrcStructFlattenerMaker(boolean binaryAsString, boolean disocverNestedFields)
Review Comment:
nit: typo in name of parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
