clintropolis commented on code in PR #13672:
URL: https://github.com/apache/druid/pull/13672#discussion_r1072898133
##########
core/src/main/java/org/apache/druid/java/util/common/parsers/JSONFlattenerMaker.java:
##########
@@ -57,15 +57,21 @@ public class JSONFlattenerMaker implements
ObjectFlatteners.FlattenerMaker<JsonN
private final CharsetEncoder enc = StandardCharsets.UTF_8.newEncoder();
private final boolean keepNullValues;
+ private final boolean discoverNestedFields;
- public JSONFlattenerMaker(boolean keepNullValues)
+
+ public JSONFlattenerMaker(boolean keepNullValues, boolean
discoverNestedFields)
{
this.keepNullValues = keepNullValues;
+ this.discoverNestedFields = discoverNestedFields;
}
@Override
public Iterable<String> discoverRootFields(final JsonNode obj)
{
+ if (discoverNestedFields) {
Review Comment:
do you want similar comments for all the other FlattenerMaker
implementations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
