clintropolis commented on code in PR #13672:
URL: https://github.com/apache/druid/pull/13672#discussion_r1070880532
##########
core/src/main/java/org/apache/druid/java/util/common/parsers/JSONPathParser.java:
##########
@@ -42,7 +42,11 @@ public class JSONPathParser implements Parser<String, Object>
public JSONPathParser(JSONPathSpec flattenSpec, ObjectMapper mapper, boolean
keepNullColumns)
{
this.mapper = mapper == null ? new ObjectMapper() : mapper;
- this.flattener = ObjectFlatteners.create(flattenSpec, new
JSONFlattenerMaker(keepNullColumns));
+ this.flattener = ObjectFlatteners.create(
+ flattenSpec,
+ new JSONFlattenerMaker(keepNullColumns),
+ false
Review Comment:
this and other `Parser` based implementations are hard coded to false to
retain existing behavior for Hadoop ingestion. `Parser` are not created with a
`InputRowSchema` the same way as `InputEntityReader` are, so I don't have easy
access to a `TuningConfig`, and I wasn't very motivated to fix this up for
Hadoop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
