rohangarg commented on code in PR #13368:
URL: https://github.com/apache/druid/pull/13368#discussion_r1081128163
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -562,13 +563,30 @@ private QueryDefinition initializeQueryDefAndState(final
Closer closer)
.orElse(MSQWarnings.DEFAULT_MAX_PARSE_EXCEPTIONS_ALLOWED);
}
-
+ ImmutableMap.Builder<String, Object> taskContextOverridesBuilder =
ImmutableMap.builder();
+ taskContextOverridesBuilder
+ .put(
+ MultiStageQueryContext.CTX_ENABLE_DURABLE_SHUFFLE_STORAGE,
+ isDurableStageStorageEnabled
+ ).put(
+
MultiStageQueryContext.CTX_COMPOSED_INTERMEDIATE_SUPER_SORTER_STORAGE,
+
MultiStageQueryContext.isComposedIntermediateSuperSorterStorageEnabled(
+ task.getQuerySpec().getQuery().context()
+ )
+ ).put(
Review Comment:
I think they can work independently - the local bytes limit just enforces a
resource limit on the local storage and the composition storage enables joining
local disk and durable storage together.
Currently, the `CTX_INTERMEDIATE_SUPER_SORTER_STORAGE_MAX_LOCAL_BYTES` is
defaulted as `Long.MAX_VALUE` and is used in the normal flow as well to keep
consistency. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
