rohangarg commented on code in PR #13368:
URL: https://github.com/apache/druid/pull/13368#discussion_r1081135950
##########
processing/src/main/java/org/apache/druid/frame/processor/OutputChannelFactory.java:
##########
@@ -31,6 +31,11 @@
*/
OutputChannel openChannel(int partitionNumber) throws IOException;
+ /**
+ * Create a channel pair tagged with a particular name and a flag to delete
the channel data after its read.
+ */
+ PartitionedOutputChannel openPartitionedChannel(String name, boolean
deleteAfterRead) throws IOException;
Review Comment:
1. the name is not a partition name, but rather a generic name for the
channel which can contain multiple partitions.
2. FrameFiles can be shared amongst multiple independent readers currently -
and they are deleted only when all references to the file are removed. So,
that's why had to pass the deletion flag down to the channel creator. A
cleaning factory could be created but then it would also have to do ref
counting per frame file before cleaning.
##########
processing/src/main/java/org/apache/druid/frame/util/DurableStorageUtils.java:
##########
@@ -102,4 +102,20 @@ public static String
getPartitionOutputsFileNameForPartition(
partitionNumber
);
}
+
+
Review Comment:
added javadocs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
