rohangarg commented on code in PR #13368:
URL: https://github.com/apache/druid/pull/13368#discussion_r1081130351
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/CountingOutputChannelFactory.java:
##########
@@ -50,7 +51,22 @@ public OutputChannel openChannel(int partitionNumber) throws
IOException
new CountingWritableFrameChannel(
baseChannel.getWritableChannel(),
channelCounters,
- baseChannel.getPartitionNumber()
+ partitionNumber
+ )
+ );
+ }
+
+ @Override
+ public PartitionedOutputChannel openPartitionedChannel(String name, boolean
deleteAfterRead) throws IOException
+ {
+ final PartitionedOutputChannel baseChannel =
baseFactory.openPartitionedChannel(name, deleteAfterRead);
+
+ return baseChannel.mapWritableChannel(
+ baseWritableChannel ->
+ new CountingWritableFrameChannel(
+ baseChannel.getWritableChannel(),
+ channelCounters,
+ null
Review Comment:
It is passed because the channel can contain multiple partitions, so the
partition number is looked upon every frame being written
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
