cryptoe commented on code in PR #13368:
URL: https://github.com/apache/druid/pull/13368#discussion_r1081143362
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -562,13 +563,30 @@ private QueryDefinition initializeQueryDefAndState(final
Closer closer)
.orElse(MSQWarnings.DEFAULT_MAX_PARSE_EXCEPTIONS_ALLOWED);
}
-
+ ImmutableMap.Builder<String, Object> taskContextOverridesBuilder =
ImmutableMap.builder();
+ taskContextOverridesBuilder
+ .put(
+ MultiStageQueryContext.CTX_ENABLE_DURABLE_SHUFFLE_STORAGE,
+ isDurableStageStorageEnabled
+ ).put(
+
MultiStageQueryContext.CTX_COMPOSED_INTERMEDIATE_SUPER_SORTER_STORAGE,
+
MultiStageQueryContext.isComposedIntermediateSuperSorterStorageEnabled(
+ task.getQuerySpec().getQuery().context()
+ )
+ ).put(
Review Comment:
I think we should throw an error if one sets
CTX_COMPOSED_INTERMEDIATE_SUPER_SORTER_STORAGE and
CTX_INTERMEDIATE_SUPER_SORTER_STORAGE_MAX_LOCAL_BYTES is not set.
What will happen is the users will set this flag thinking stuff is going to
work but they would be proved wrong.
As @paul-rogers, throwing errors is a way for people to force reading
documentation ^-^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
