rohangarg commented on code in PR #13368:
URL: https://github.com/apache/druid/pull/13368#discussion_r1082340975
##########
processing/src/main/java/org/apache/druid/frame/file/FrameFile.java:
##########
@@ -246,7 +246,8 @@ static FrameFile open(
log.warn("Could not delete frame file [%s]", file);
}
if (byteTracker != null) {
- byteTracker.release(fileLength);
+ // only release the bytes taken by frames, we don't track the
header and footer as of now
Review Comment:
this was needed since we're not tracking header and footer size as of now
(due to difficulties with empty frame files). I have added an explanation for
this in the code - it could be picked up in the future if needed.
Also, the assumption is that frame data would be much larger than the header
+ footer sizes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
