jwitko commented on code in PR #13747:
URL: https://github.com/apache/druid/pull/13747#discussion_r1106685564
##########
helm/druid/README.md:
##########
@@ -199,6 +225,11 @@ The following table lists the configurable parameters of
the Druid chart and the
| `router.replicaCount` | router node replicas (deployment)
| `1` |
| `router.port` | port of router component
| `8888` |
| `router.serviceType` | service type for service
| `ClusterIP` |
+| `router.serviceAccount.create` | Create a service account for
router service | `true` |
+| `router.serviceAccount.name` | Service account name
| `` |
Review Comment:
The default name is template derived so there is no way to put a value here
that is guaranteed to be accurate. It's a combination of the
`druid.<service>.fullname` template which is based off the `druid.fullname`
template and the service name. Most of which can be overridden.
```
{{- define "druid.fullname" -}}
{{- if .Values.fullnameOverride -}}
{{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" -}}
{{- else -}}
{{- $name := default .Chart.Name .Values.nameOverride -}}
{{- if contains $name .Release.Name -}}
{{- .Release.Name | trunc 63 | trimSuffix "-" -}}
{{- else -}}
{{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" -}}
{{- end -}}
{{- end -}}
{{- end -}}
```
```
{{- define "druid.broker.fullname" -}}
{{ template "druid.fullname" . }}-{{ .Values.broker.name }}
{{- end -}}
```
```
{{/*
Create the name of the broker service account
*/}}
{{- define "druid.broker.serviceAccountName" -}}
{{- if .Values.broker.serviceAccount.create }}
{{- default (include "druid.broker.fullname" .)
.Values.broker.serviceAccount.name }}
{{- else }}
{{- default "default" .Values.broker.serviceAccount.name }}
{{- end }}
{{- end }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
