jwitko commented on code in PR #13747:
URL: https://github.com/apache/druid/pull/13747#discussion_r1106689531
##########
helm/druid/templates/historical/roleBinding.yaml:
##########
@@ -0,0 +1,20 @@
+{{- if and (.Values.rbac.create) (.Values.historical.enabled) }}
+apiVersion: rbac.authorization.k8s.io/v1
+kind: RoleBinding
+metadata:
+ name: {{ template "druid.historical.fullname" . }}
+ labels:
+ app: {{ include "druid.name" . }}
+ chart: {{ include "druid.chart" . }}
+ component: {{ .Values.historical.name }}
+ release: {{ .Release.Name }}
+ heritage: {{ .Release.Service }}
+roleRef:
+ apiGroup: rbac.authorization.k8s.io
+ kind: Role
+ name: {{ template "druid.historical.fullname" . }}
+subjects:
+ - kind: ServiceAccount
+ name: {{ .Values.historical.serviceAccount.name }}
Review Comment:
Thank you for catching this. This was a left-over from before @dampcake
recommended switching to the empty default value above in this PR and my
testing had already had the `.Values.*.serviceAccount.name` values set from
previous as well so I wasn't getting an issue here.
Fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
