paul-rogers commented on code in PR #13815:
URL: https://github.com/apache/druid/pull/13815#discussion_r1114897553
##########
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java:
##########
@@ -1572,12 +1566,12 @@ protected DataStoreMetadataUpdateResult
updateDataSourceMetadataWithHandle(
if (!startMetadataMatchesExisting) {
// Not in the desired start state.
- log.error(
- "Not updating metadata, existing state[%s] in metadata store doesn't
match to the new start state[%s].",
+ return new DataStoreMetadataUpdateResult(true, false, StringUtils.format(
+ "Not updating metadata, existing state[%s] in metadata store doesn't
match to the new start state[%s]." +
+ " This usually happens if the input stream is changed within the
same supervisor.",
Review Comment:
Let's see if I can now understand the issue from the error message. The user
has a supervisor. They change the Kafka topic name from which that Supervisor
reads? When they do that, they have to actually create a new supervisor (i.e.
same spec, new name) and remove the old one?
If so, the key wording is "change the input topic name".
Though, this raises a question: why can't we detect that this happened and
"do the right thing"? (Though, that is probably a separate PR.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
