abhishekagarwal87 commented on code in PR #13815:
URL: https://github.com/apache/druid/pull/13815#discussion_r1115480983
##########
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java:
##########
@@ -1605,7 +1599,13 @@ protected DataStoreMetadataUpdateResult
updateDataSourceMetadataWithHandle(
.bind("commit_metadata_sha1",
newCommitMetadataSha1)
.execute();
- retVal = numRows == 1 ? DataStoreMetadataUpdateResult.SUCCESS :
DataStoreMetadataUpdateResult.TRY_AGAIN;
+ retVal = numRows == 1
+ ? DataStoreMetadataUpdateResult.SUCCESS
+ : new DataStoreMetadataUpdateResult(
+ true,
+ true,
+ "Failed to insert metadata for datasource [%s]",
Review Comment:
It's kinda like an internal server error. even I don't know what will cause
this error. and there is not much information available. it's one of those
cases that are unlikely to occur but have been added as a safety check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
