abhishekagarwal87 commented on code in PR #13815:
URL: https://github.com/apache/druid/pull/13815#discussion_r1115476145
##########
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java:
##########
@@ -1572,12 +1566,12 @@ protected DataStoreMetadataUpdateResult
updateDataSourceMetadataWithHandle(
if (!startMetadataMatchesExisting) {
// Not in the desired start state.
- log.error(
- "Not updating metadata, existing state[%s] in metadata store doesn't
match to the new start state[%s].",
+ return new DataStoreMetadataUpdateResult(true, false, StringUtils.format(
+ "Not updating metadata, existing state[%s] in metadata store doesn't
match to the new start state[%s]." +
+ " This usually happens if the input stream is changed within the
same supervisor.",
Review Comment:
Well doing the right thing could involve some data loss. Thinking a bit
more, we could disallow changing the topic name entirely in the same
supervisor. If you want to change the topic name, then you have to terminate
the existing supervisor and create a new one. Though yes, it could be a
separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
