paul-rogers commented on code in PR #13815:
URL: https://github.com/apache/druid/pull/13815#discussion_r1114906779
##########
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java:
##########
@@ -191,7 +191,8 @@ public boolean hasNext()
{
final long thisTimeoutNanos = timeoutAtNanos -
System.nanoTime();
if (hasTimeout && thisTimeoutNanos < 0) {
- throw new QueryTimeoutException("Sequence iterator timed
out");
+ throw new QueryTimeoutException("Query did not complete
within configured timeout period. " +
+ "You can increase query timeout or tune the performance
of query");
Review Comment:
As you noted, in another PR, we are trying to improve our error system. This
is a perfect example. _If_ we had that system available (which we don't yet),
we could solve by throwing, say, a `QueryTimeoutError` with the following
message and context:
```text
Query timed out.
Timeout seconds: xx
Suggestion: Review query logs to improve performance, or change the timeout
period.
```
It seems that the code above only knows the timeout time, but not the
original timeout period. This would be a case where a higher bit of code would
catch the timeout exception and fill in the `Timeout seconds` value.
The `Suggestion` applies to simple Druid installations, but perhaps not to
managed Druid where an end user has no access to the logs or the config
parameters. Such systems could strip out the suggestion or substitute their own.
But, of course, we don't have this system yet. The result is that the above
rather lackluster message is about all we can offer at the moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
