clintropolis commented on code in PR #13803:
URL: https://github.com/apache/druid/pull/13803#discussion_r1141629623
##########
processing/src/main/java/org/apache/druid/segment/nested/GlobalDimensionDictionary.java:
##########
@@ -42,45 +47,107 @@
private final ComparatorDimensionDictionary<String> stringDictionary;
private final ComparatorDimensionDictionary<Long> longDictionary;
private final ComparatorDimensionDictionary<Double> doubleDictionary;
+ private final Set<Object[]> stringArrays;
+ private final Set<Object[]> longArrays;
+ private final Set<Object[]> doubleArrays;
Review Comment:
this is also used for merging segments, so the original ints they referred
to might have been remapped when the string/long/double dictionaries are merged
beneath them, so we have to round trip like this to lookup the new values
##########
processing/src/main/java/org/apache/druid/segment/nested/NestedDataColumnSerializer.java:
##########
@@ -104,6 +108,32 @@ public StructuredDataProcessor.ProcessedLiteral<?>
processLiteralField(ArrayList
}
return StructuredDataProcessor.ProcessedLiteral.NULL_LITERAL;
}
+
+ @Nullable
+ @Override
+ public ProcessedLiteral<?> processArrayOfLiteralsField(
+ ArrayList<NestedPathPart> fieldPath,
+ @Nullable Object maybeArrayOfLiterals
+ )
+ {
+ ExprEval<?> eval = ExprEval.bestEffortOf(maybeArrayOfLiterals);
+ if (eval.type().isArray() && eval.type().getElementType().isPrimitive())
{
+ final GlobalDictionaryEncodedFieldColumnWriter<?> writer =
fieldWriters.get(
+ NestedPathFinder.toNormalizedJsonPath(fieldPath)
+ );
+ if (writer != null) {
+ try {
+ writer.addValue(rowCount, eval.value());
+ // serializer doesn't use size estimate
+ return StructuredDataProcessor.ProcessedLiteral.NULL_LITERAL;
+ }
+ catch (IOException e) {
+ throw new RuntimeException(":(");
Review Comment:
oops yes, this was a placeholder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
