clintropolis commented on code in PR #13803:
URL: https://github.com/apache/druid/pull/13803#discussion_r1141630196
##########
processing/src/main/java/org/apache/druid/segment/nested/NestedDataColumnSerializer.java:
##########
@@ -251,33 +313,78 @@ public void serializeStringDictionary(Iterable<String>
dictionaryValues) throws
dictionaryWriter.write(value);
globalDictionaryIdLookup.addString(value);
}
+ stringDictionarySerialized = true;
}
public void serializeLongDictionary(Iterable<Long> dictionaryValues) throws
IOException
{
+ if (!stringDictionarySerialized) {
+ throw new ISE("Must serialize string value dictionary before serializing
long dictionary for column [%s]", name);
+ }
+ if (longDictionarySerialized) {
+ throw new ISE("Long dictionary already serialized for column [%s],
cannot serialize again", name);
+ }
for (Long value : dictionaryValues) {
if (value == null) {
continue;
}
longDictionaryWriter.write(value);
globalDictionaryIdLookup.addLong(value);
}
+ longDictionarySerialized = true;
}
public void serializeDoubleDictionary(Iterable<Double> dictionaryValues)
throws IOException
{
+ if (!stringDictionarySerialized) {
+ throw new ISE("Must serialize string value dictionary before serializing
double dictionary for column [%s]", name);
+ }
+ if (!longDictionarySerialized) {
+ throw new ISE("Must serialize long value dictionary before serializing
double dictionary for column [%s]", name);
+ }
+ if (doubleDictionarySerialized) {
+ throw new ISE("Double dictionary already serialized for column [%s],
cannot serialize again", name);
+ }
for (Double value : dictionaryValues) {
if (value == null) {
continue;
}
doubleDictionaryWriter.write(value);
globalDictionaryIdLookup.addDouble(value);
}
+ doubleDictionarySerialized = true;
+ }
+
+ public void serializeArrayDictionary(Iterable<int[]> dictionaryValues)
throws IOException
+ {
+ if (!stringDictionarySerialized) {
+ throw new ISE("Must serialize string value dictionary before serializing
array dictionary for column [%s]", name);
+ }
+ if (!longDictionarySerialized) {
+ throw new ISE("Must serialize long value dictionary before serializing
array dictionary for column [%s]", name);
+ }
+ if (!doubleDictionarySerialized) {
+ throw new ISE("Must serialize double value dictionary before serializing
array dictionary for column [%s]", name);
+ }
+ if (arrayDictionarySerialized) {
+ throw new ISE("Array dictionary already serialized for column [%s],
cannot serialize again", name);
+ }
Review Comment:
yeah i agree it could use refactored, i added the exceptions to at least
enforce this is done correctly because it was previously true as well just
nothing was checking it, will look into making some adjustments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
